Enable workflows to request a TEE by nolag · Pull Request #2004 · smartcontractkit/chainlink-common

nolag · 2026-04-28T15:03:11Z

No description provided.

…back

github-actions · 2026-04-28T15:04:44Z

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

⚠️ Breaking Changes (11)

`pkg/workflows/wasm/host` (3)

ExecutionHelper — Type changed:

  - ExecutionHelper
  + github.com/smartcontractkit/chainlink-common/pkg/workflows/host.ExecutionHelper
)

ModuleBase — Type changed:

  - ModuleBase
  + github.com/smartcontractkit/chainlink-common/pkg/workflows/host.ModuleBase
)

ModuleV2 — Type changed:

  - ModuleV2
  + github.com/smartcontractkit/chainlink-common/pkg/workflows/host.Module
)

`pkg/workflows/wasm/host.(*module)` (1)

Execute — Type changed:

func(
  context.Context, 
  *github.com/smartcontractkit/chainlink-protos/cre/go/sdk.ExecuteRequest, 
  ExecutionHelper
)
(*github.com/smartcontractkit/chainlink-protos/cre/go/sdk.ExecutionResult, error)

`pkg/workflows/wasm/host/mocks` (7)

ModuleV2 — Type changed:

  - ModuleV2
  + github.com/smartcontractkit/chainlink-common/pkg/workflows/host/mocks.Module
)

ModuleV2_Close_Call — 🗑️ Removed
ModuleV2_Execute_Call — 🗑️ Removed
ModuleV2_Expecter — 🗑️ Removed
ModuleV2_IsLegacyDAG_Call — 🗑️ Removed
ModuleV2_Start_Call — 🗑️ Removed
NewModuleV2 — Type changed:

func(
  interface{Cleanup(func()); github.com/stretchr/testify/mock.TestingT}
)
*ModuleV2

✅ Compatible Changes (3)

`package github` (3)

com/smartcontractkit/chainlink-common/pkg/workflows/host — ➕ Added
com/smartcontractkit/chainlink-common/pkg/workflows/host/mocks — ➕ Added
com/smartcontractkit/chainlink-common/pkg/workflows/host/requirements_gen — ➕ Added

📄 View full apidiff report

…for the decision

…mbedded request

…, not just region.

…rotos from the cap-devs

jmank88 · 2026-06-01T15:08:45Z

 func SendSubscription(subscriptions *sdk.TriggerSubscriptionRequest) {
 	execResult := &sdk.ExecutionResult{Result: &sdk.ExecutionResult_TriggerSubscriptions{TriggerSubscriptions: subscriptions}}
 	sendResponse(BufferToPointerLen(Must(proto.Marshal(execResult))))
+	os.Exit(0)


Was this for testing?

no, it should have been there the whole time. Other tests just didn't do anything after calling it.

Can you leave a comment explaining? This doesn't make any sense to me without context

The SendError function above it does the same thing.

It's a very dumbed down version of this code in the real SDK.

The internal one here is for bootstrapping, we can test the standard tests work, and that we can do things correctly with modules without needing the SDK.

The SDK needs the standard tests to verify correct behaviour, so we can't create a circular dependency. Also, the goal is to test the host/guest interactions at a lower level to ensure it works before we ask the SDKs to implement it for their language

jmank88 · 2026-06-01T15:33:52Z

@erikburt Is API Diff failing here? These aliases are meant to be 100% compatible.

Edit: Wait, did it correct itself? maybe I just saw a stale comment

jmank88 · 2026-06-01T16:01:40Z

@erikburt Is API Diff failing here? These aliases are meant to be 100% compatible.

Edit: Wait, did it correct itself? maybe I just saw a stale comment

Oh actually it is updating the two comments separately I guess? That may be confusing. But the main problem is that aliases seem to show as breaking.

* Add TeeEnabled to template generator, and add a new requirements callback * Add region * Requirements selecting runner * update proto and fix requirement not met test * Update proto, allow individual triggers to choose where to run * Add max time for requirements selection * Use subscription for the trigger requirement * Main module satisfies requirements * remove unused hook from module, the selecting one is now responsible for the decision * Hook to ask implementation to determine if it supports regions * Update protos to use full TEE requirement and not use bytes for the embedded request * Send full requirements to modules that accept them * Regions with any is allowed too, and let the TEE say everything it is, not just region. * Update protos for unknown TEE Type * Fix misc tests that were fixed on a different branch, update to use protos from the cap-devs * Remove file left from prior genreation and update to use the one from the public package * AI feedback addressed * Pin artifacts test build * Undo whitespaces changes to unrealated files * Cleaner go version pinning * Undo whitespaces changes to unrealated files * Use slices.Contains in template_generator * Undo whitespaces changes to unrealated files * Revert whitespace changes for real...

nolag added 8 commits April 14, 2026 09:30

Add TeeEnabled to template generator, and add a new requirements call…

b5d368d

…back

Add region

660e58a

Requirements selecting runner

4294618

Merge branch 'main' into rtinianov_teeWorkflows

0a4ed20

update proto and fix requirement not met test

a869861

Update proto, allow individual triggers to choose where to run

16dba12

Add max time for requirements selection

cf01251

Use subscription for the trigger requirement

b8745af

nolag added 2 commits April 28, 2026 12:48

Main module satisfies requirements

2b8b244

remove unused hook from module, the selecting one is now responsible …

58ec02d

…for the decision

nolag force-pushed the rtinianov_teeWorkflows branch from f98af19 to f4e51a4 Compare April 30, 2026 14:41

Hook to ask implementation to determine if it supports regions

937bc20

nolag force-pushed the rtinianov_teeWorkflows branch from f4e51a4 to 937bc20 Compare April 30, 2026 15:09

Update protos to use full TEE requirement and not use bytes for the e…

e578b91

…mbedded request

nolag force-pushed the rtinianov_teeWorkflows branch 2 times, most recently from 8441040 to da5bccc Compare May 1, 2026 13:26

Send full requirements to modules that accept them

98d72c5

nolag force-pushed the rtinianov_teeWorkflows branch 3 times, most recently from d5fedb0 to e01fae1 Compare May 1, 2026 17:56

Regions with any is allowed too, and let the TEE say everything it is…

8e8598d

…, not just region.

nolag force-pushed the rtinianov_teeWorkflows branch from e01fae1 to 8e8598d Compare May 1, 2026 19:13

nolag added 4 commits May 4, 2026 12:14

Update protos for unknown TEE Type

f0dfd6b

Merge branch 'main' into rtinianov_teeWorkflows

b213255

Fix misc tests that were fixed on a different branch, update to use p…

3860740

…rotos from the cap-devs

Merge branch 'main' into rtinianov_teeWorkflows

179ae0e

nolag changed the title ~~Rtinianov tee workflows~~ Enable workflows to request a TEE May 20, 2026

nolag marked this pull request as ready for review May 20, 2026 19:34

nolag requested a review from a team as a code owner May 20, 2026 19:34

Merge branch 'main' into rtinianov_teeWorkflows

8a3236b

russell-stern previously approved these changes Jun 1, 2026

View reviewed changes

jmank88 reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/workflows/host/tee_selection_provider.go

jmank88 reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/workflows/artifacts/utils.go Outdated

jmank88 reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/workflows/artifacts/utils.go Outdated

jmank88 requested a review from erikburt June 1, 2026 15:26

Cleaner go version pinning

fad5acc

nolag dismissed russell-stern’s stale review via fad5acc June 1, 2026 15:34

nolag requested review from jmank88 and russell-stern June 1, 2026 15:34

jmank88 reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/capabilities/v2/protoc/pkg/template_generator.go Outdated

nolag added 3 commits June 1, 2026 11:45

Undo whitespaces changes to unrealated files

9f4470d

Use slices.Contains in template_generator

b4959b4

Undo whitespaces changes to unrealated files

0577b0d

nolag requested a review from jmank88 June 1, 2026 15:51

jmank88 previously approved these changes Jun 1, 2026

View reviewed changes

Revert whitespace changes for real...

a8c273f

nolag dismissed jmank88’s stale review via a8c273f June 1, 2026 16:06

nolag requested a review from jmank88 June 1, 2026 16:06

jmank88 approved these changes Jun 1, 2026

View reviewed changes

jmank88 enabled auto-merge June 1, 2026 16:10

DylanTinianov approved these changes Jun 1, 2026

View reviewed changes

jmank88 added this pull request to the merge queue Jun 1, 2026

Merged via the queue into main with commit 5b4f632 Jun 1, 2026
31 of 33 checks passed

jmank88 deleted the rtinianov_teeWorkflows branch June 1, 2026 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable workflows to request a TEE#2004

Enable workflows to request a TEE#2004
jmank88 merged 31 commits into
mainfrom
rtinianov_teeWorkflows

nolag commented Apr 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

jmank88 Jun 1, 2026

Uh oh!

nolag Jun 1, 2026

Uh oh!

jmank88 Jun 1, 2026

Uh oh!

nolag Jun 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmank88 commented Jun 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

jmank88 commented Jun 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

nolag commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (11)

pkg/workflows/wasm/host (3)

pkg/workflows/wasm/host.(*module) (1)

pkg/workflows/wasm/host/mocks (7)

✅ Compatible Changes (3)

package github (3)

Uh oh!

jmank88 Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

nolag Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

jmank88 Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

nolag Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmank88 commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jmank88 commented Jun 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nolag commented Apr 28, 2026 •

edited

Loading

github-actions Bot commented Apr 28, 2026 •

edited

Loading

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

`pkg/workflows/wasm/host` (3)

`pkg/workflows/wasm/host.(*module)` (1)

`pkg/workflows/wasm/host/mocks` (7)

`package github` (3)

jmank88 commented Jun 1, 2026 •

edited

Loading